Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape HTML characters in the indicator search variable tooltip. #1527

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Escape HTML characters in the indicator search variable tooltip. #1527

merged 6 commits into from
Nov 30, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Nov 14, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds a JS function to escape HTML characters.

Does this PR introduce a breaking change?

Other information:

@github-actions github-actions bot added the docs Improvements to documenation label Nov 14, 2023
@huard huard requested a review from SarahG-579462 November 15, 2023 19:44
SarahG-579462
SarahG-579462 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@SarahG-579462 SarahG-579462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, recommend using the function elsewhere as well though!

docs/_static/indsearch.js Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Nov 16, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.445%. first build
when pulling 912fc78 on fix-1524
into d382912 on master.

@huard huard merged commit 2413df4 into master Nov 30, 2023
16 checks passed
@huard huard deleted the fix-1524 branch November 30, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahG-579462 SarahG-579462 SarahG-579462 approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: Search - indicator variable tooltip
4 participants
@huard @coveralls @SarahG-579462 @Zeitsperre